#119 Fix SVG export

Added specific handling of SVG extension
MaxMelcher · Feb 26, 2023 · f1901b7 · f1901b7
1 parent ece9193
commit f1901b7
Show file tree

Hide file tree

Showing 7 changed files with 65 additions and 3 deletions.
diff --git a/AzureDevOps.WikiPDFExport.Test/WikiPDFExporterTests.cs b/AzureDevOps.WikiPDFExport.Test/WikiPDFExporterTests.cs
@@ -20,6 +20,7 @@ public class WikiPDFExporterTests
         [InlineData("EmptyOrderFile")]
         [InlineData("Flat")]
         [InlineData("WellFormed")]
+        [InlineData("PngSvgExport")]
         public async void ExportWiki_IncludeUnlistedPages_Succeeds(string wikiToExport)
         {
             var options = new Options
@@ -53,6 +54,7 @@ public async void ExportWiki_IncludeUnlistedPages_Succeeds(string wikiToExport)
         [InlineData("Flat")]
         [InlineData("WellFormed")]
         [InlineData("SingleFileNoOrder")]
+        [InlineData("PngSvgExport")]
         public async void ExportWiki_OnlyOrderListedPages_Succeeds(string wikiToExport)
         {
             var options = new Options

diff --git a/AzureDevOps.WikiPDFExport.Test/test-data/Expected/IncludeUnlistedPages/PngSvgExport.pdf.html b/AzureDevOps.WikiPDFExport.Test/test-data/Expected/IncludeUnlistedPages/PngSvgExport.pdf.html
diff --git a/AzureDevOps.WikiPDFExport.Test/test-data/Expected/OrderListedPages/PngSvgExport.pdf.html b/AzureDevOps.WikiPDFExport.Test/test-data/Expected/OrderListedPages/PngSvgExport.pdf.html
diff --git a/AzureDevOps.WikiPDFExport.Test/test-data/Inputs/PngSvgExport/.attachments/test.png b/AzureDevOps.WikiPDFExport.Test/test-data/Inputs/PngSvgExport/.attachments/test.png
diff --git a/AzureDevOps.WikiPDFExport.Test/test-data/Inputs/PngSvgExport/.attachments/test.svg b/AzureDevOps.WikiPDFExport.Test/test-data/Inputs/PngSvgExport/.attachments/test.svg
diff --git a/AzureDevOps.WikiPDFExport.Test/test-data/Inputs/PngSvgExport/Page-With-Svg.md b/AzureDevOps.WikiPDFExport.Test/test-data/Inputs/PngSvgExport/Page-With-Svg.md
@@ -0,0 +1,12 @@
+# Premise
+This is a wiki page to test export PNG and SVG
+
+---
+
+# PNG
+![test.png](./.attachments/test.png)
+
+---
+
+# SVG
+![test.svg](./.attachments/test.svg)
diff --git a/AzureDevOps.WikiPDFExport/MarkdownConverter.cs b/AzureDevOps.WikiPDFExport/MarkdownConverter.cs
@@ -416,9 +416,8 @@ public void CorrectLinksAndImages(MarkdownObject document, MarkdownFile mf)
                             {
                                 //convert images to base64 and embed them in the html. Chrome/Puppeter does not show local files because of security reasons.
                                 Byte[] bytes = File.ReadAllBytes(fileInfo.FullName);
-                                String base64 = Convert.ToBase64String(bytes);
-
-                                link.Url = $"data:image/{fileInfo.Extension};base64,{base64}";
+                                var base64 = Convert.ToBase64String(bytes);
+                                link.Url = $"data:image/{(fileInfo.Extension == ".svg" ? "svg+xml" : fileInfo.Extension)};base64,{base64}";
                             }
 
                             fileInfo = new FileInfo($"{absPath}.md");