Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG files not supported #119

Closed
svdoever opened this issue Aug 10, 2022 · 4 comments
Closed

SVG files not supported #119

svdoever opened this issue Aug 10, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers inactive
Milestone
Version 4.5

Comments

@svdoever
Copy link

SVG files which show correctly in Wiki are not exported into the PDF.
This is a pity for the *.excalidraw.svg files with embeded excalidraw information, I will move them to exacalidraw.png files.
@stale
Copy link

stale bot commented Oct 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Oct 9, 2022
@MaxMelcher MaxMelcher added enhancement New feature or request good first issue Good for newcomers and removed inactive labels Oct 11, 2022
@MaxMelcher MaxMelcher added this to the Version 4.5 milestone Oct 11, 2022
@stale
Copy link

stale bot commented Dec 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Dec 12, 2022
@stale stale bot closed this as completed Dec 20, 2022
@matteotrapani
Copy link

Hello,

@MaxMelcher first of all thank you for this amazing tool!
I found the same issue described here since export with SVGs is not working for me.

I made some fixes and I'm going to open a PR for you meanwhile.
Should this issue be reopened?

@matteotrapani matteotrapani mentioned this issue Feb 21, 2023
Merged
MaxMelcher pushed a commit that referenced this issue Feb 26, 2023
@MaxMelcher
#119 Fix SVG export
f1901b7 
Added specific handling of SVG extension
@MaxMelcher
Copy link
Owner

@matteotrapani thanks, even with unit tests 👍👍👍
Will release it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers inactive
Projects
None yet
Milestone
Version 4.5
Development

No branches or pull requests
3 participants
@svdoever @MaxMelcher @matteotrapani