Add multiple slang-tidy checks and minor fixes in existing ones #1040
Conversation
This new check enforces that each always_comb block is named
This new check enforces that each generate block is named. This also is applied to the for block
This check ensures that no module instantiation uses the sintax '.var' in the port connection, and ensures that '.var(var)' is used instead
Now, when '.*' is used with the NoDotStarInPortConnection check enabled, the warning will be located where the '.*' character is, instead of the location of the module that was being called.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
=======================================
Coverage 94.70% 94.71%
=======================================
Files 191 191
Lines 47655 47655
=======================================
+ Hits 45133 45135 +2
+ Misses 2522 2520 -2 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
JoelSole-Semidyn
force-pushed
the
dev/slang-tidy
branch
from
b54022e
to
b9e5877
Compare
|
I have not reviewed all of the current Tidy checks, so my apologies if this is covered. Rather than having separate options to flag the use of for/if blocks inside |
This new check enforces that no generate block is used in the code, since it is an old system verilog syntax
This new synthesis check ensures that if there is a conditional block with reset, all the assignments must be either inside the if or else statements.
This new check verifies that every signal inside the sensitivity list of an 'always' or 'always_ff' block is used inside the block statement. The only exception is the clock signal
* slang-tidy fix OnlyAssignedOnReset and RegisterHasNoReset: This commit will ensure that both checks will no longer be ignoring the configuration setting 'resetIsActiveHigh' and the possible negation of the reset signal. Two test cases have also been added to consider this bug. * The error location of the warnings generated by the OnlyAssignedOnReset and RegisterHasNoReset are now more precise and target the variable instance where the error is found instead of the variable declaration.
JoelSole-Semidyn
force-pushed
the
dev/slang-tidy
branch
from
49289a3
to
aaddd1c
Compare
|
You are totally right, so I just uploaded a new version with the check NoLegacyGenerate instead of NoForInsideGenerate
|
…slang into dev/slang-tidy * 'dev/slang-tidy' of https://github.com/JoelSole-Semidyn/slang: style: pre-commit fixes
…dev/slang-tidy * 'master' of https://github.com/MikePopoloski/slang: Update CHANGELOG.md [slang] Fix PLA task concatenation ascending order (MikePopoloski#1047) [slang] Fix PATHPULSE limit values (MikePopoloski#1048) Handle recursive parameter definitions via hierarchical reference Mark fmt lib headers as system headers to suppress warnings Bump dependency versions: fmt and pybind11 [slang] Make string simple type (MikePopoloski#1049) Update README.md (MikePopoloski#1046) [slang][port] Fix bugs (MikePopoloski#1043) Use [[likely]] / [[unlikely]] replace macro SLANG_LIKELY/SLANG_UNLIKELY (MikePopoloski#1038) Add multiple slang-tidy checks and minor fixes in existing ones (MikePopoloski#1040) chore: update pre-commit hooks (MikePopoloski#1041)
…dev/slang-tidy * 'master' of https://github.com/MikePopoloski/slang: Fix a bug in the tidy-check UnusedSensitiveSignal (MikePopoloski#1056) Update CHANGELOG.md [slang] Fix PLA task concatenation ascending order (MikePopoloski#1047) [slang] Fix PATHPULSE limit values (MikePopoloski#1048) Handle recursive parameter definitions via hierarchical reference Mark fmt lib headers as system headers to suppress warnings Bump dependency versions: fmt and pybind11 [slang] Make string simple type (MikePopoloski#1049) Update README.md (MikePopoloski#1046) [slang][port] Fix bugs (MikePopoloski#1043) Use [[likely]] / [[unlikely]] replace macro SLANG_LIKELY/SLANG_UNLIKELY (MikePopoloski#1038) Add multiple slang-tidy checks and minor fixes in existing ones (MikePopoloski#1040) chore: update pre-commit hooks (MikePopoloski#1041)
This PR adds some new slang-tidy checks, along with some minor fixes to existing ones, mainly aiming to throw the warnings in a more precise location. The new slang-tidy checks added to this PR are the following:
style checks
AlwaysCombNamed
This check ensures that all always_comb blocks have a name
GenerateNamed
Similar to the previous check, this ensures that all generate blocks are named, including for loops
NoDotVarInPortConnection
A check analogous to NoDotStarInPortConnection, enforces that no '.var' is used in port connection, and '.var(var)' should be used instead
NoLegacyGenerate
This check enforces that no generate block is used in the code, since it is an old system verilog syntax
synthesis checks
AlwaysFFAssignmentOutsideConditional
Check that ensures that if there is a conditional block with reset, all the assignments must be either inside the if or else statements
UnusedSensitiveSignal
This check verifies that every signal inside the sensitivity list of an 'always' or 'always_ff' block is used inside the block statement. The only exception is the clock signal