[slang] Fix PATHPULSE limit values #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 191 191
Lines 47656 47662 +6
=======================================
+ Hits 45136 45142 +6
Misses 2520 2520
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
source/parsing/Parser_members.cpp
Outdated
| @@ -3227,7 +3227,7 @@ SpecparamDeclaratorSyntax& Parser::parseSpecparamDeclarator(SyntaxKind parentKin | |||
| if (parentKind != SyntaxKind::SpecifyBlock) | |||
| addDiag(diag::PulseControlSpecifyParent, name.range()); | |||
| else if (!expr2) | |||
| addDiag(diag::PulseControlTwoValues, expr1.sourceRange()) << name.range(); | |||
| expr2 = &expr1; | |||
There was a problem hiding this comment.
This should not duplicate the expression here -- leaving it null seems fine. The parse tree must maintain the property that visiting the tokens in it via depth-first traversal recovers the original source file as typed by the user.
There was a problem hiding this comment.
fixed in last commit with simple code refactoring
JoelSole-Semidyn
added a commit
to JoelSole-Semidyn/slang
that referenced
this pull request
Jul 12, 2024
…dev/slang-tidy * 'master' of https://github.com/MikePopoloski/slang: Update CHANGELOG.md [slang] Fix PLA task concatenation ascending order (MikePopoloski#1047) [slang] Fix PATHPULSE limit values (MikePopoloski#1048) Handle recursive parameter definitions via hierarchical reference Mark fmt lib headers as system headers to suppress warnings Bump dependency versions: fmt and pybind11 [slang] Make string simple type (MikePopoloski#1049) Update README.md (MikePopoloski#1046) [slang][port] Fix bugs (MikePopoloski#1043) Use [[likely]] / [[unlikely]] replace macro SLANG_LIKELY/SLANG_UNLIKELY (MikePopoloski#1038) Add multiple slang-tidy checks and minor fixes in existing ones (MikePopoloski#1040) chore: update pre-commit hooks (MikePopoloski#1041)
JoelSole-Semidyn
pushed a commit
to JoelSole-Semidyn/slang
that referenced
this pull request
Jul 15, 2024
JoelSole-Semidyn
added a commit
to JoelSole-Semidyn/slang
that referenced
this pull request
Jul 15, 2024
…dev/slang-tidy * 'master' of https://github.com/MikePopoloski/slang: Fix a bug in the tidy-check UnusedSensitiveSignal (MikePopoloski#1056) Update CHANGELOG.md [slang] Fix PLA task concatenation ascending order (MikePopoloski#1047) [slang] Fix PATHPULSE limit values (MikePopoloski#1048) Handle recursive parameter definitions via hierarchical reference Mark fmt lib headers as system headers to suppress warnings Bump dependency versions: fmt and pybind11 [slang] Make string simple type (MikePopoloski#1049) Update README.md (MikePopoloski#1046) [slang][port] Fix bugs (MikePopoloski#1043) Use [[likely]] / [[unlikely]] replace macro SLANG_LIKELY/SLANG_UNLIKELY (MikePopoloski#1038) Add multiple slang-tidy checks and minor fixes in existing ones (MikePopoloski#1040) chore: update pre-commit hooks (MikePopoloski#1041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to
SystemVerilogLRM grammar it is legal to specialize only 1 value for bothPATHPULSE$reject and error limits.According to 30.7.1 section:
At the text below LRM says:
"The path (data=>q) is not explicitly defined in any of the PATHPULSE$ declarations; therefore, it acquires reject and error limit of 3, as defined by the last PATHPULSE$ declaration." for such example: