Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: skip treewide PRs #211845

Merged
merged 2 commits into from
Jan 20, 2023
Merged

github actions: skip treewide PRs #211845

merged 2 commits into from
Jan 20, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 20, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@zowoq zowoq requested review from a team and Mic92 as code owners January 20, 2023 23:22
@zowoq zowoq changed the title github actions [skip treewide] github actions: skip treewide PRs Jan 20, 2023
@zowoq
Copy link
Contributor Author

zowoq commented Jan 20, 2023

Forgot that it needs to be in the base branch for it to work so testing it on this PR won't work.

I'll go through the other PRs and change them to skip treewide after this is merged.

https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+%5Bskip+editorconfig%5D

cc @0x4A6F

@zowoq zowoq requested a review from infinisil January 20, 2023 23:27
@zowoq
Copy link
Contributor Author

zowoq commented Jan 20, 2023

@infinisil As it needs to be read from the base branch you'll need to rebase on top of master after this is merged.

@zowoq zowoq merged commit d157042 into NixOS:master Jan 20, 2023
@zowoq zowoq deleted the gha-treewide branch January 20, 2023 23:34
@risicle
Copy link
Contributor

risicle commented Jan 21, 2023

I think this is fine from a security POV because it's not like our workflows make hard restrictions anyway and the flag is visible and transparent.

@infinisil
Copy link
Member

Context for this: #211832 which made all CI runs run into API rate limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants