[RFC 140 2b] pkgs/by-name: Automated migration
#211832
Draft
+274
−21,442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
force-pushed
the
auto-calling
branch
from
cfc6b31
to
550c1db
Compare
infinisil
changed the title
infinisil
force-pushed
the
auto-calling
branch
from
550c1db
to
fef9e79
Compare
zowoq
changed the title
|
|
|
|
infinisil
added a commit
to infinisil/nixpkgs
that referenced
this pull request
Jan 20, 2023
NixOS#211832 broke the workflows for all PR's temporarily because it runs into GitHub API limits. This change to the workflow files just makes sure that the problematic workflows don't run for that specific PR.
zowoq
changed the title
infinisil
force-pushed
the
auto-calling
branch
3 times, most recently
from
a06330e
to
35c73e4
Compare
Makes the build independency of the default.nix and update.sh file by explicitly specifying the files that are needed in the result This allows changing those files without causing a rebuild
This way, changing the Nix file won't change the derivation
Tested with nix-env -qaf . The res -> super changes are necessary because res points to the result of the current overlay, but some of the packages were moved to the previous overlay, which can be accessed with super. This is a fundamental problem to be fixed, see NixOS#55061 and related issues The schleuder change is necessary because the ./default.nix file referenced ./., but there's also another package in ./bin. The tool couldn't move the gemfiles in ./. because The schleuder change is necessary because the tool isn't smart enough and this is a special case of the default.nix reading gemfiles from a ./. reference and there being both schleuder in pkgs/tools/security/schleuder and schleuder-cli in pkgs/tools/security/schleuder/cli
infinisil
force-pushed
the
auto-calling
branch
from
35c73e4
to
5727203
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-01-23-nixpkgs-architecture-team-meeting-26/24892/1 |
This was referenced Jan 24, 2023
This was referenced Jan 30, 2023
infinisil
added
the
significant
Testing backports for moved files
infinisil
changed the title
13 tasks
12 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-09-05-nixpkgs-architecture-team-meeting-43/32635/1 |
This was referenced Sep 11, 2023
|
I'm planning to implement this in a series of steps: #258650 |
iFreilicht
reviewed
Oct 30, 2023
| @@ -17,7 +17,7 @@ jobs: | |||
| contents: write # for korthout/backport-action to create branch | |||
| pull-requests: write # for korthout/backport-action to create PR to backport | |||
| name: Backport Pull Request | |||
| if: github.repository_owner == 'NixOS' && github.event.pull_request.merged == true && (github.event_name != 'labeled' || startsWith('backport', github.event.label.name)) | |||
There was a problem hiding this comment.
I think this should be changed back after this PR has been merged, otherwise this workflow might run in every contributors repo as well, right?
There was a problem hiding this comment.
Oh yeah I only used this for testing. I'll have to completely update this PR once everything is ready.
This was referenced Nov 7, 2023
infinisil
changed the title
pkgs/by-name: Automated migration
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/ci-will-soon-enforce-pkgs-by-name-for-new-packages/38098/1 |
wegank
added
the
2.status: stale
3 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the second part of the implementation of the accepted RFC 140, the automated migration. The first part is already done and can be found here: #237439.
The plan for the second part can be found here: #258650
This is hopefully only the first of many quality-of-life improvements to Nixpkgs by the Nixpkgs Architecture Team.
This PR is currently an old draft of the implementation, using a slightly hacky tool to do it. Will be updated after part 1 is done.
TODO