Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gambatte: move package to pkgs/applications/emulators #251064

Closed
wants to merge 1 commit into from

Conversation

romatthe
Copy link
Contributor

Description of changes

I noticed that the Gambatte package was still listed under pkgs/games, so this mini-PR just moves it to pkgs/applications/emulators.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ajs124
Copy link
Member

ajs124 commented Aug 25, 2023

please just drop this package instead of giving me more work rebasing #174634

@ehmry
Copy link
Contributor

ehmry commented Sep 2, 2023

The directory structure is going to be reorganized soon - #211832, I'd just leave this where it is.

@ajs124 ajs124 closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants