Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Formats.Asn1 into Version.Details.xml #5956

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

akoeplinger
Copy link
Contributor

@akoeplinger akoeplinger commented Aug 6, 2024

This is required for source-build to upgrade the dependency to the live version.

Otherwise we'll hit downgrade errors like this:

error NU1605: Warning As Error: Detected package downgrade: System.Formats.Asn1 from 9.0.0-rc.1.24403.1 to 8.0.1.

Bug

Fixes:

Description

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

This is required for source-build to upgrade the dependency to the live version.

Otherwise we'll hit downgrade errors like this:
> error NU1605: Warning As Error: Detected package downgrade: System.Formats.Asn1 from 9.0.0-rc.1.24403.1 to 8.0.1.
@akoeplinger akoeplinger requested a review from a team as a code owner August 6, 2024 12:11
@dotnet-policy-service dotnet-policy-service bot added the Community PRs created by someone not in the NuGet team label Aug 6, 2024
@akoeplinger
Copy link
Contributor Author

/cc @zivkan @nkolev92

@nkolev92 nkolev92 enabled auto-merge (squash) August 6, 2024 17:12
@nkolev92 nkolev92 added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Aug 6, 2024
@nkolev92 nkolev92 merged commit 912acef into NuGet:dev Aug 6, 2024
28 checks passed
@akoeplinger akoeplinger deleted the patch-2 branch August 6, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants