Allow override of System.Formats.Asn1 package version #5959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
Nigusu-Allehu
approved these changes
Aug 7, 2024
zivkan
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the changes from #5956 because they were incomplete. In addition to a dependency being defined for
System.Formats.Asn1, there also needs to be a way to override that package version via the<package-name>PackageVersionproperty pattern. This property gets set by .NET source build, which requires overriding package versions.Without this change, the original issue described in #5956 isn't fixed.
/cc @nkolev92, @akoeplinger
Bug
Fixes:
Description
PR Checklist