Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor values can be duplicated when populating a continuous factor #1185

Open
arteymix opened this issue Jul 13, 2024 · 1 comment
Open
Labels
bug needs confirmation Issues that need to be confirmed or reliably reproduced

Comments

@arteymix
Copy link
Member

We have this dataset that have a continuous factor with duplicated FVs at the sample level, one of the value being a bunch of nulls (they have a non-null measurement though with the exact same value).

I'm not exactly sure how this can happen. I think I will add extra validation to prevent BMs from being updated if they have a duplicated factor value and from there we might catch the actual culprit.

Original issue: https://github.com/PavlidisLab/GemmaCuration/issues/538

@arteymix arteymix added bug needs confirmation Issues that need to be confirmed or reliably reproduced labels Jul 13, 2024
@arteymix
Copy link
Member Author

arteymix commented Jul 13, 2024

This issue should be prevented by 4823b39 and fc43bd9. I've introduced additional validation for FVs and BMs to prevent invalid states to be created/updated.

I'll keep this open as we might be able to identify the cause now that it will produce an error.

@arteymix arteymix added this to the 1.31.10 milestone Jul 13, 2024
@arteymix arteymix removed this from the 1.31.10 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs confirmation Issues that need to be confirmed or reliably reproduced
Projects
None yet
Development

No branches or pull requests

1 participant