ignore site for submissions with same batchUid (WP-874) #518
Conversation
…e present (WP-874)
| if ($activeProfileCount !== 1) { | ||
| $this->getLogger()->notice("Active profile count=$activeProfileCount while processing upload of submission"); | ||
| } | ||
| $params[SubmissionEntity::FIELD_TARGET_BLOG_ID] = $this->getSettingsManager() |
There was a problem hiding this comment.
I don't understand how it worked before and now. You add the filter by target locale, as result you automatically exclude all other locales. So the code below will not work as expected
/**
* Looking for other locales to pass filters and create placeholders.
*/
$submissions = $this->getSubmissionManager()->find($params);There was a problem hiding this comment.
Before, this always took a single applicable profile and added a filter based on the profile's target blogs.
My assumption is that when multiple active profiles are present for a source blog, the plugin might take one that doesn't have all target blogs, so after the change, I expect source blog filter to be applied only if the profile is the only applicable profile. I've added a test in #519
There was a problem hiding this comment.
Ok, I even didn't think about such case.
But even if we assume that the client has a single profile, I still suspect we will do multiple uploads.
No description provided.