refactor (WP-874) #519
Open
refactor (WP-874) #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e present (WP-874)
# Conflicts: # inc/Smartling/Base/SmartlingCoreTrait.php # tests/Smartling/Base/SmartlingCoreTest.php # tests/Smartling/Base/SmartlingCoreUploadTraitTest.php
PavelLoparev
approved these changes
Feb 27, 2024
Comment on lines
-96
to
+98
| $this->getContentHelper()->ensureTargetBlogId($submission); | ||
| $this->siteHelper->withBlog($submission->getTargetBlogId(), function () use ($submission) { |
There was a problem hiding this comment.
It was ensureTargetBlogId now it's withBlog, is it expected change? I thought you've just got rid of traits and moved everything inside classes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controversial, because on one side, I'm not a fan of the god object. On the other side, however, having traits that pretend they're usable without the root object makes it really harder to write tests and understand code in general.