-[ASNetworkImageNode setURL:resetToDefault:] forget to reset animated…

…Image (#1861)

* Fix -[ASNetworkImageNode setURL:resetToDefault:] forget to reset animatedImage

* add ASNetworkImageNodeTest for reset with animatedImage

Source/ASNetworkImageNode.mm

@@ -216,6 +216,7 @@ - (void)setURL:(NSURL *)URL resetToDefault:(BOOL)reset
     if (reset || hadURL) {
       [self _setCurrentImageQuality:(hadURL ? 0.0 : 1.0)];
       [self _locked__setImage:_defaultImage];
+      [self _locked_setAnimatedImage:nil];
     }
   }
 

Tests/ASNetworkImageNodeTests.mm

@@ -20,6 +20,9 @@ @interface ASTestImageDownloader : NSObject <ASImageDownloaderProtocol>
 @interface ASTestImageCache : NSObject <ASImageCacheProtocol>
 @end
 
+@interface ASTestAnimatedImage : NSObject <ASAnimatedImageProtocol>
+@end
+
 @implementation ASNetworkImageNodeTests {
   ASNetworkImageNode *node;
   id downloader;
@@ -73,6 +76,18 @@ - (void)testThatProgressBlockIsSetAndClearedCorrectlyOnChangeURL
   [downloader verifyWithDelay:5];
 }
 
+- (void)testThatAnimatedImageClearedCorrectlyOnChangeURL
+{
+  [node layer];
+  [node enterInterfaceState:ASInterfaceStateInHierarchy];
+
+  // Set URL while visible, should set progress block
+  node.animatedImage = [ASTestAnimatedImage new];
+  [node setURL:[NSURL URLWithString:@"http://imageA"] resetToDefault:YES];
+
+  XCTAssertEqualObjects(nil, node.animatedImage);
+}
+
 - (void)testThatSettingAnImageWillStayForEnteringAndExitingPreloadState
 {
   UIImage *image = [[UIImage alloc] init];
@@ -133,3 +148,61 @@ - (void)setProgressImageBlock:(ASImageDownloaderProgressImage)progressBlock call
   // nop
 }
 @end
+
+@implementation ASTestAnimatedImage
+@synthesize playbackReadyCallback;
+
+- (UIImage *)coverImage
+{
+  return [UIImage new];
+}
+
+- (BOOL)coverImageReady
+{
+  return YES;
+}
+
+- (CFTimeInterval)totalDuration
+{
+  return 1;
+}
+
+- (NSUInteger)frameInterval
+{
+  return 0.2;
+}
+
+- (size_t)loopCount
+{
+  return 0;
+}
+
+- (size_t)frameCount
+{
+  return 5;
+}
+
+- (BOOL)playbackReady
+{
+  return YES;
+}
+
+- (NSError *)error
+{
+  return nil;
+}
+
+- (CGImageRef)imageAtIndex:(NSUInteger)index
+{
+  return [[UIImage new] CGImage];
+}
+
+- (CFTimeInterval)durationAtIndex:(NSUInteger)index
+{
+  return 0.2;
+}
+
+- (void)clearAnimatedImageCache
+{}
+
+@end