-[ASNetworkImageNode setURL:resetToDefault:] forget to reset animatedImage #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please add a unit tests that fails without this code change, and succeeds with it. This will make it harder for the behavior to regress. |
|
@bolsinga unit tests added I wonder, should also clear animatedImage when a static image is download finish? |
Thank you!
I don't know enough about that. However, I do think it would be best in a separate PR! |
bolsinga
approved these changes
Jun 16, 2020
garrettmoon
pushed a commit
that referenced
this pull request
Jun 25, 2020
…Image (#1861) * Fix -[ASNetworkImageNode setURL:resetToDefault:] forget to reset animatedImage * add ASNetworkImageNodeTest for reset with animatedImage
piotrdebosz
pushed a commit
to getstoryteller/Texture
that referenced
this pull request
Mar 1, 2021
…Image (TextureGroup#1861) * Fix -[ASNetworkImageNode setURL:resetToDefault:] forget to reset animatedImage * add ASNetworkImageNodeTest for reset with animatedImage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a ASNetworkImageNode with animatedImage
Then you call [ImageNode setURL:someLink resetToDefault:true]
Node will still always display Old animatedImage, the new static image will never be display
Related issue #1815