Avoid triggering main thread assertions in collection/table dealloc #…

…trivial (#803) * Avoid triggering main thread assertions in ASCollectionNode/ASTableNode dealloc * Put it back
TextureGroup · Feb 13, 2018 · 8b43173 · 8b43173
1 parent e2478fc
commit 8b43173
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/Source/ASCollectionNode.mm b/Source/ASCollectionNode.mm
@@ -172,12 +172,17 @@ - (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionVi
   return self;
 }
 
+#if ASDISPLAYNODE_ASSERTIONS_ENABLED
 - (void)dealloc
 {
-  if ([self isNodeLoaded]) {
-    ASDisplayNodeAssert(self.view.superview == nil, @"Node's view should be removed from hierarchy.");
+  if (self.nodeLoaded) {
+    __weak UIView *view = self.view;
+    ASPerformBlockOnMainThread(^{
+      ASDisplayNodeCAssertNil(view.superview, @"Node's view should be removed from hierarchy.");
+    });
   }
 }
+#endif
 
 #pragma mark ASDisplayNode
 

diff --git a/Source/ASTableNode.mm b/Source/ASTableNode.mm
@@ -104,12 +104,17 @@ - (instancetype)init
   return [self initWithStyle:UITableViewStylePlain];
 }
 
+#if ASDISPLAYNODE_ASSERTIONS_ENABLED
 - (void)dealloc
 {
-  if ([self isNodeLoaded]) {
-    ASDisplayNodeAssert(self.view.superview == nil, @"Node's view should be removed from hierarchy.");
+  if (self.nodeLoaded) {
+    __weak UIView *view = self.view;
+    ASPerformBlockOnMainThread(^{
+      ASDisplayNodeCAssertNil(view.superview, @"Node's view should be removed from hierarchy.");
+    });
   }
 }
+#endif
 
 #pragma mark ASDisplayNode