Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid triggering main thread assertions in collection/table dealloc #trivial #803

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Avoid triggering main thread assertions in collection/table dealloc #trivial #803

merged 2 commits into from
Feb 13, 2018

Conversation

Adlai-Holler
Copy link
Member

@Adlai-Holler Adlai-Holler commented Feb 13, 2018 •
edited
Loading

In #793 a new assertion was introduced that inadvertently triggered main thread checker failures.

This avoids triggering the same thing.

@Adlai-Holler
Copy link
Member Author

As I think about it, I wonder if view.superview should be replaced by view.window. It's not relevant to this diff, but I wonder how others feel about it from a theoretical correctness standpoint.

@Adlai-Holler Adlai-Holler changed the title Avoid triggering main thread assertions in collection/table dealloc Avoid triggering main thread assertions in collection/table dealloc #trivial Feb 13, 2018
nguyenhuy
nguyenhuy approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nguyenhuy
Copy link
Member

#804

@Adlai-Holler
Copy link
Member Author

Alright it's time to go big. Landing!

@Adlai-Holler Adlai-Holler merged commit 8b43173 into master Feb 13, 2018
@Adlai-Holler Adlai-Holler deleted the AHCollectionDealloc branch February 13, 2018 20:02
@nguyenhuy nguyenhuy mentioned this pull request Feb 13, 2018
Closed
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
@Adlai-Holler @bernieperez
Avoid triggering main thread assertions in collection/table dealloc #…
34baac7 
…trivial (TextureGroup#803)

* Avoid triggering main thread assertions in ASCollectionNode/ASTableNode dealloc

* Put it back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@nguyenhuy nguyenhuy nguyenhuy approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@appleguy appleguy Awaiting requested review from appleguy

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Adlai-Holler @nguyenhuy @maicki