[ASTableNode & ASCollectionNode] Keepalive reference for node if their view is necessarily alive (has a superview). #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleguy
changed the title
|
This effectively replaces the keepalive reference that is in _ASDisplayView, since that code is not able to be used when subclassing UICollectionView and UITableView. (Even though we do have a +layerClass of _ASDisplayLayer for these cases). |
Generated by 🚫 Danger |
appleguy
changed the title
appleguy
approved these changes
Feb 9, 2018
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…r view is necessarily alive (has a superview). (TextureGroup#793) * fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * Keep collection/table node alive if view still in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some uses will try to access view and maintain it for later use.
This PR will try to keep collection/tableNode alive as long as corresponding view still in use (may not in hierarchy), similar to ASDisplayNode & ASDisplayView.