Skip to content

Commit

Permalink
Guard photo library with macro for tests (#1147)
Browse files Browse the repository at this point in the history
* fix SIMULATE_WEB_RESPONSE not imported #449

* Fix to make rangeMode update in right time

* remove uncessary assert

* Fix collection cell editing bug for iOS 9 & 10

* Revert "Fix collection cell editing bug for iOS 9 & 10"

This reverts commit 06e18a1.

* Only test when photo library is enabled.

It will fail to build if photo library is disabled cause the test is
depending on it.

* Add ChangeLog.
  • Loading branch information
wsdwsd0829 authored and nguyenhuy committed Sep 28, 2018
1 parent 5dd5611 commit f656dbb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## master
* Add your own contributions to the next release on the line below this with your name.
- [ASPhotosFrameworkImageRequestTests] Guard photo library with macro for tests. [Max Wang](https://github.com/wsdwsd0829). [#1147](https://github.com/TextureGroup/Texture/pull/1147)
- [ASDisplayNode] Do not cancel display when in exit hierarchy but let interface state changing to handle it. [Max Wang](https://github.com/wsdwsd0829). [#1110](https://github.com/TextureGroup/Texture/pull/1110)
- [Breaking][ASDisplayNode] Make interface state delegate protocol required. [Max Wang](https://github.com/wsdwsd0829). [#1112](https://github.com/TextureGroup/Texture/pull/1112)
- [ASCollectionView] Fix reording of cells manually for iOS 9 & 10. [Max Wang](https://github.com/wsdwsd0829). [#1081](https://github.com/TextureGroup/Texture/pull/1081)
Expand Down
4 changes: 4 additions & 0 deletions Tests/ASPhotosFrameworkImageRequestTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
//

#if AS_USE_PHOTOS

#import <XCTest/XCTest.h>
#import <AsyncDisplayKit/ASPhotosFrameworkImageRequest.h>

Expand Down Expand Up @@ -59,3 +61,5 @@ - (void)testThatCopyingWorks
}

@end

#endif

0 comments on commit f656dbb

Please sign in to comment.