Guard photo library with macro for tests #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06e18a1.
It will fail to build if photo library is disabled cause the test is depending on it.
nguyenhuy
approved these changes
Sep 27, 2018
|
🚫 CI failed with log |
|
CI was flaky. The commit with actual code changes passed, so I'm gonna land this. |
|
@wsdwsd0829 Thanks for the fix, btw. |
|
Ok, Thanks.
…On Fri, Sep 28, 2018 at 9:15 AM Huy Nguyen ***@***.***> wrote:
Merged #1147 <#1147> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1147 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFFq5HcOy2f-7MW6YOpeaCaeshs_eEhMks5ufksGgaJpZM4W9O02>
.
|
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Only test when photo library is enabled. It will fail to build if photo library is disabled cause the test is depending on it. * Add ChangeLog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.