-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter locking assertions #1024
Merged
nguyenhuy
merged 9 commits into
TextureGroup:master
from
nguyenhuy:HN-Stricter-Locking-Safety-Checks
Jul 13, 2018
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c037799
Stricter locking assertions
nguyenhuy c2bdd1a
Rename to ASAssertLocked and ASAssertUnlocked
nguyenhuy 48b7fa1
Revert unnecessary change
nguyenhuy b454388
Rename -_isNodeLoaded to -_unsafe_unlocked_isNodeLoaded
nguyenhuy 49c21ae
Use inline method
nguyenhuy 372ff89
Merge branch 'master' into HN-Stricter-Locking-Safety-Checks
Adlai-Holler 0325062
Move __loaded(node) macro to ASDisplayNodeInternal and use it throughout
nguyenhuy 4dd528f
Merge branch 'HN-Stricter-Locking-Safety-Checks' of github.com:nguyen…
nguyenhuy f4234df
Simpler node loaded check: regardless of whether the node is view or …
nguyenhuy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easier to just call the "unlocked" variant.