Remove objc association & weak proxy from node -> controller pointer #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we can't import ASDisplayNodeInternal from C
maicki
approved these changes
Aug 3, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…extureGroup#1061) * Remove objc association & weak proxy from node -> controller relationship * Rename ASNodeController+Beta.m to ASNodeControllerx+Beta.mm Currently we can't import ASDisplayNodeInternal from C * Update project pointers * Rename ASNodeControllerx+Beta.mm to ASNodeController+Beta.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Objective-C associated objects are built on nested
hash_mapand are pretty slow. Also weak proxies slow down traffic and take time to construct and tear down. We can optimize this pretty easily.Changes
ASNodeController *ivars to ASDisplayNode+Internal.initoverride that adds nothing.