Remove direct ivar access on non-self object to fix mocking case #trivial #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he object is actually a mock
maicki
approved these changes
Aug 3, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…vial (TextureGroup#1066) * Remove direct ivar access on non-self object to prevent issues when the object is actually a mock * Comment * Remove lock to avoid deadlock risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1061, if your unit tests use mock nodes you may get a crash because we access ivars on the mock display node. It is unsafe to access ivars on mock objects.
This diff makes it so that we send the node a message. If it's a mock, the mocking system will forward the message to the real instance.