[ASImageNode] Fix a threading issue which can cause a display completion block to never be executed #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nguyenhuy
commented
Sep 28, 2018
•
nguyenhuy
commented
- Clear _displayCompletionBlock while we still have the node's instance lock. Because it may not be the same block by the time the lock is reacquired. In other words, it can happen that another thread sets a new display block after this thread releases the lock but before it reacquires it. And we don't want to clear out the new block.
- Reduce a lock/unlock pair which should help perf a tiny bit.
nguyenhuy
force-pushed
the
HN-Fix-Display-Completion-Block
branch
from
eda62ab
to
aa9e796
Compare
nguyenhuy
requested review from
garrettmoon,
Adlai-Holler,
maicki and
appleguy
appleguy
approved these changes
Oct 21, 2018
| if (shouldPerformDisplayCompletionBlock) { | ||
| _displayCompletionBlock = nil; | ||
| } | ||
|
|
||
| BOOL hasDebugLabel = (_debugLabelNode != nil); |
There was a problem hiding this comment.
Since many of the calls in the debug label section require the lock anyway (like self.bounds), should we just continue holding the lock until after that?
There was a problem hiding this comment.
There's a comment below stating that we don't care about locking in the debug section. I don't remember the reasoning behind that (locking violation somehow?), but let's revisit it in another PR.
CHANGELOG.md
Outdated
| @@ -57,6 +57,7 @@ | |||
| - Clean up timing of layout tree flattening/ copying of unflattened tree for Weaver. [Michael Zuccarino](https://github.com/mikezucc) [#1157](https://github.com/TextureGroup/Texture/pull/1157) | |||
| - Fix crash setting attributed text on multiple threads [Michael Schneider](https://github.com/maicki) | |||
| - [ASTextNode2] Ignore certain text alignments while calculating intrinsic size [Huy Nguyen](https://github.com/nguyenhuy) [#1166](https://github.com/TextureGroup/Texture/pull/1166) | |||
| - [ASImageNode] Fix a threading issue which can cause a display completion block to never be executed. [Huy Nguyen](https://github.com/nguyenhuy) [#1148](https://github.com/TextureGroup/Texture/pull/1148) | |||
There was a problem hiding this comment.
From the header file, it isn't too clear that calling the method multiple times will overwrite the previous block without calling it. In order to guarantee balanced calls, we'd probably need to track them with an array.
This seems like an increasingly common case in the framework (even interfaceStateDelegates now), so it might be worth creating a helper class like ASBlockList / ASBlockQueue to manage efficiently. Not important right now, just an idea.
There was a problem hiding this comment.
Agree that it'd be nice to have track all blocks in an array.
Adlai-Holler
approved these changes
Oct 22, 2018
nguyenhuy
force-pushed
the
HN-Fix-Display-Completion-Block
branch
from
3494455
to
ce4bb1c
Compare
…ode's instance lock - Because it may not be the same block by the time the lock is reacquired. In other words, it can happen that another thread sets a new display block after this thread releases the lock but before it reacquires it. And we don't want to clear out the new block. - Reduce a lock/unlock pair which should help perf a tiny bit.
nguyenhuy
force-pushed
the
HN-Fix-Display-Completion-Block
branch
from
ce4bb1c
to
3a35a9a
Compare
|
🚫 CI failed with log |
|
🚫 CI failed with log |
Generated by 🚫 Danger |
nguyenhuy
changed the title
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
…tion block to never be executed (TextureGroup#1148) - Clear _displayCompletionBlock while we still have the node's instance lock. Because it may not be the same block by the time the lock is reacquired. In other words, it can happen that another thread sets a new display block after this thread releases the lock but before it reacquires it. And we don't want to clear out the new block. - Reduce a lock/unlock pair which should help perf a tiny bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.