Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASImageNode] Fix a threading issue which can cause a display completion block to never be executed #1148

Merged
merged 1 commit into from
Nov 5, 2018
Merged

[ASImageNode] Fix a threading issue which can cause a display completion block to never be executed #1148

merged 1 commit into from
Nov 5, 2018

Commits on Nov 4, 2018

  1. [ASImageNode] Clear _displayCompletionBlock while we still have the n… 

    …ode's instance lock

- Because it may not be the same block by the time the lock is reacquired. In other words, it can happen that another thread sets a new display block after this thread releases the lock but before it reacquires it. And we don't want to clear out the new block.
- Reduce a lock/unlock pair which should help perf a tiny bit.
    @nguyenhuy
    nguyenhuy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    3a35a9a View commit details
    Browse the repository at this point in the history