Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CircleCI #1210

Closed
wants to merge 18 commits into from
Closed

Set up CircleCI #1210

wants to merge 18 commits into from

Conversation

Adlai-Holler
Copy link
Member

@Adlai-Holler Adlai-Holler commented Nov 2, 2018

@maicki @appleguy @nguyenhuy @garrettmoon

What do we think? CircleCI is working, and fast. Unit tests finish in 7 minutes, and the last test (examples-pt2) finishes about 7 minutes later). Pricing is here https://circleci.com/pricing/#build-os-x

Notes:

  • Bumps to Xcode 10.1 from 9.0.1
  • Totally sandboxed – each run is its own VM.
  • Ownership at CircleCI mirrors GitHub ownership, so any member of TextureGroup will have control over the CI.
  • All CI status pages are visible to the public.
  • No need to unblock builds. I think any member of the public can re-run the CI on their own PRs too.

All we have to do is decide:

  • Do we want to do this? It costs money and it is a change but it will let us move and scale a lot faster.
  • Who will pay for it? Pricing is here: https://circleci.com/pricing/#build-os-x Currently I'm paying for the Seed plan ($40/mo) which I think is comparable to the current setup.
  • Are there any details we want to tweak?

If we decide to do it, all we have to do is:

  • Land this PR.
  • Remove the branch filter from the config.yml file in this PR.
  • Turn the GitHub integration back on (off now because other diffs break).
  • Turn off buildkite.
  • Replace build.sh with build-new.sh and update config.
  • Any open diffs should rebase to get CI going.

Build list: https://circleci.com/gh/TextureGroup/Texture

@TextureGroup TextureGroup deleted a comment Nov 4, 2018
@TextureGroup TextureGroup deleted a comment Nov 4, 2018
@TextureGroup TextureGroup deleted a comment Nov 4, 2018
@Adlai-Holler Adlai-Holler requested review from garrettmoon, maicki, nguyenhuy and appleguy and removed request for garrettmoon and maicki November 4, 2018 20:59
@TextureGroup TextureGroup deleted a comment Nov 5, 2018
@Adlai-Holler Adlai-Holler force-pushed the AHCircleCI branch 2 times, most recently from f0a64f5 to 2f5b3f4 Compare November 6, 2018 17:05
@TextureGroup TextureGroup deleted a comment Nov 6, 2018
@TextureGroup TextureGroup deleted a comment Nov 6, 2018
@TextureGroup TextureGroup deleted a comment Nov 6, 2018
@TextureGroup TextureGroup deleted a comment Nov 7, 2018
@Adlai-Holler Adlai-Holler force-pushed the AHCircleCI branch 2 times, most recently from 5cb166a to 695a803 Compare November 7, 2018 17:58
@TextureGroup TextureGroup deleted a comment Nov 7, 2018
@TextureGroup TextureGroup deleted a comment Nov 7, 2018
@TextureGroup TextureGroup deleted a comment Nov 7, 2018
@Adlai-Holler Adlai-Holler changed the title Set up CircleCI [Ignore CI build failure!!] Set up CircleCI Nov 7, 2018
@Adlai-Holler Adlai-Holler changed the title [Ignore CI build failure!!] Set up CircleCI Set up CircleCI Nov 7, 2018
@Adlai-Holler Adlai-Holler force-pushed the AHCircleCI branch 2 times, most recently from 6452022 to b535b8d Compare November 7, 2018 18:46
@TextureGroup TextureGroup deleted a comment Nov 7, 2018
@ghost
Copy link

ghost commented Nov 8, 2018

🚫 CI failed with log

@TextureGroup TextureGroup deleted a comment Nov 8, 2018
@garrettmoon
Copy link
Member

@Adlai-Holler with regards to pricing, how long do the builds take on circle ci? The pricing indicates 500 minutes a month for the $40.

# - {attach_workspace: {at: ~/project}}
- checkout
- {run: {name: 'Fetch cocoapods spec repo from cache', command: "curl https://cocoapods-specs.circleci.com/fetch-cocoapods-repo-from-s3.sh | bash -s cf\n"}}
- {run: xcrun simctl list}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't, the simulator engine sometimes barfs when it comes time to run

@@ -0,0 +1,189 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why to create a new .sh file instead of updating the existing one? It would be nice for people to still be able to invoke a build script via command line and not have it diverge over time from the one CI was running. I see the pod install is happening elsewhere now, maybe we can use another ENV var or argument to disable it and then keep just one file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a leftover from the development of the diff. If we want to do this I will replace the old build.sh before landing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No time like the present! Are you anticipating a lag between merging the PR and actually running CI on CircleCI?

@nguyenhuy nguyenhuy mentioned this pull request Aug 17, 2019
7 tasks
@nguyenhuy
Copy link
Member

@Adlai-Holler let’s close this in favor of GitHub CI. It’s free for open source projects with no limitations that I know of. And it’s fast too!

@nguyenhuy nguyenhuy closed this Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants