Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up GitHub Actions CI #1623

Merged
merged 6 commits into from
Aug 18, 2019
Merged

Set up GitHub Actions CI #1623

merged 6 commits into from
Aug 18, 2019

Conversation

nguyenhuy
Copy link
Member

@nguyenhuy nguyenhuy commented Aug 17, 2019

GitHub Actions now supports CI and it's free for open source projects!

Our current CI (BuildKite) runs on a single machine and needs 1h 20m for each build. GitHub CI often finishes everything in less than 10m!

The setup is straight-forward. The only missing feature is the ability to exclude certain files so that if a commit only contains those files, the CI won't test it at all (see exclude-from-build.json). Given that GitHub CI is fast and is not a serial queue, I wouldn't mind testing such commit as well.

Follow-up tasks if we land this:

@nguyenhuy nguyenhuy force-pushed the HN-Actions branch 3 times, most recently from 7b54e5f to 7c02019 Compare August 17, 2019 14:41
@nguyenhuy nguyenhuy changed the title [WIP] Set up GitHub Actions CI Set up GitHub Actions CI Aug 17, 2019
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

- examples-pt3 builds the same examples as examples-pt1 instead of building the remaining projects. So I fixed it.
- Add another mode (examples-pt4) to distribute the load with existing steps.
- Build extra examples (examples-extra-pt{1, 2, 3}) which weren't built before.
- Each examples-pt and examples-extra-pt builds 5 projects except examples-pt4 and examples-extra-pt3 which build 6.
@nguyenhuy nguyenhuy force-pushed the HN-Actions branch 5 times, most recently from 7220daf to d67280d Compare August 17, 2019 23:17
@nguyenhuy nguyenhuy force-pushed the HN-Actions branch 6 times, most recently from df934aa to b86d2cb Compare August 18, 2019 00:00
Copy link
Member

@appleguy appleguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work on this, Huy! Definitely a big positive step for the Texture community!

@nguyenhuy
Copy link
Member Author

I’m super excited about the new CI! Thanks everyone for your reviews. Let’s get it in! I’ll follow up to deprecate BuildKite CI.

@nguyenhuy nguyenhuy merged commit 33c4b05 into master Aug 18, 2019
@nguyenhuy nguyenhuy deleted the HN-Actions branch August 19, 2019 17:03
matthewd1234 pushed a commit to matthewd1234/Texture that referenced this pull request Aug 25, 2019
GitHub Actions now supports CI and it's free for open source projects!

Our current CI runs on a single machine and needs 1h 20m for each build. GitHub CI often finishes everything in less than 10m!

The setup is straight-forward. The only missing feature is the ability to exclude certain files so that if a commit only contains those files, the CI won't test it at all (see exclude-from-build.json). Given that GitHub CI is fast and is not a serial queue, I wouldn't mind testing such commit as well.

* Fix and optimize steps that build example projects

- examples-pt3 builds the same examples as examples-pt1 instead of building the remaining projects. So I fixed it.
- Add another mode (examples-pt4) to distribute the load with existing steps.
- Build extra examples (examples-extra-pt{1, 2, 3}) which weren't built before.
- Each examples-pt and examples-extra-pt builds 5 projects except examples-pt4 and examples-extra-pt3 which build 6.

* Use HTTPS URL for Weaver in Podfile of examples/ASDKgram

* Don't build extra examples for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants