Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force -[_ASDisplayLayer setDelegate:] to evaluate delegateFlags in iOS 13 #1609

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Force -[_ASDisplayLayer setDelegate:] to evaluate delegateFlags in iOS 13 #1609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Source/ASDisplayNode.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,6 @@ - (CALayer *)_locked_layerToLoad
- (void)_locked_loadViewOrLayer
{
DISABLED_ASAssertLocked(__instanceLock__);

if (_flags.layerBacked) {
TIME_SCOPED(_debugTimeToCreateView);
_layer = [self _locked_layerToLoad];
Expand All @@ -550,6 +549,14 @@ - (void)_locked_loadViewOrLayer
_view = [self _locked_viewToLoad];
_view.asyncdisplaykit_node = self;
_layer = _view.layer;
// Needed to force `-[_ASDisplayLayer setDelegate:]` to evaluate
// It appears that UIKit might be setting the delegate ivar directly which
// bypasses establishing the `_delegateFlags` ivar on `ASDisplayLayer`
// This is critical for things like ASPagerNode, ASCollectionNode that depend
// on layer delegateFlags to forward bounds changes
if (_layer.delegate == _view) {
[_layer setDelegate:_view];
}
}
_layer.asyncdisplaykit_node = self;

Expand Down