Force -[_ASDisplayLayer setDelegate:] to evaluate delegateFlags in iOS 13
#1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iOS13. It appears that UIKit might be setting the delegate ivar directly which bypasses establishing the `_delegateFlags` ivar on `ASDisplayLayer`. This is critical for things like ASPagerNode, ASCollectionNode that depend on layer delegateFlags to forward bounds changes. Radar filed: FB6956185
nguyenhuy
approved these changes
Aug 8, 2019
|
LGTM, thanks for fixing this, @rahul-malik! Rahul also raised a question about whether it's still worth it to cache the result of |
nguyenhuy
changed the title
-[_ASDisplayLayer setDelegate:] to evaluate delegateFlags in …-[_ASDisplayLayer setDelegate:] to evaluate delegateFlags in iOS 13
|
It’s a common pattern, I’d say do it if possible, but its not exactly critical except for high frequency code paths. respondsToSelector: is class_respondsTo Selector which is basically just objc_msgSend without actually invoking the function it looked up.
In this case not critical
… On Aug 8, 2019, at 10:15 AM, Garrett Moon ***@***.***> wrote:
Merged #1609 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Great to know, thanks @Adlai-Holler! |
nguyenhuy
added a commit
to nguyenhuy/Texture
that referenced
this pull request
Aug 15, 2019
We rely on the delegate setter to be called to set the flag. However, recent change on iOS 13 causes the setter to not be called at all and thus we had to put up a workaround (TextureGroup#1609). While the workaround works, the perf benefit of that the flag provides doesn't warranty the extra complexity IMO. So I think we should just remove everything.
Adlai-Holler
pushed a commit
that referenced
this pull request
Aug 15, 2019
We rely on the delegate setter to be called to set the flag. However, recent change on iOS 13 causes the setter to not be called at all and thus we had to put up a workaround (#1609). While the workaround works, the perf benefit of that the flag provides doesn't warranty the extra complexity IMO. So I think we should just remove everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that UIKit might be setting the delegate ivar directly which bypasses establishing the
_delegateFlagsivar onASDisplayLayer. This is critical for things like ASPagerNode, ASCollectionNode that depend on layer delegateFlags to forward bounds changes.Radar filed: FB6956185
Resolves: #1595