Remove _ASDisplayLayer's delegateDidChangeBounds flag #1618
Conversation
We rely on the delegate setter to be called to set the flag. However, recent change on iOS 13 causes the setter to not be called at all and thus we had to put up a workaround (TextureGroup#1609). While the workaround works, the perf benefit of that the flag provides doesn't warranty the extra complexity IMO. So I think we should just remove everything.
There was a problem hiding this comment.
I think this is good for now, although I hate to see the msgSend & selector check on every layer every time it changes size, in practice it's not huge. However, we are in talks with Apple about putting back the setDelegate: call – which they really should do! – and if they do, we can put this back to the old code path.
|
@rahul-malik @nguyenhuy could you guys also escalate this through Apple? We are doing so as well. This is a major / unnecessary iOS behavior change that increases the risk that someday an old iOS version will get broken because of the behavior deltas. This is good to have available, but ideally multiple companies are asking for the root system bug to be fixed. |
|
@appleguy - Filed a radar a few weeks ago and will forward to our developer rep. If you have a thread you want us to chime in on let us know |
|
@rahul-malik Did you hear anything back yet from Apple regarding the Radar? Thank you! |
|
@maicki - Nothing yet from Apple on this. Have you heard anything? |
|
No we didn't, but from our investigation it seems it was changed intentionally and as soon as you link after iOS 12 the delegate call will not be called anymore. |
We rely on the delegate setter to be called to set the flag. However, a recent change in iOS 13 (beta) causes the setter to not be called at all and thus we had to put up a workaround (#1609). While the workaround works, the performance benefit that the flag provides doesn't warranty the extra complexity IMO. So I think we should just remove everything.