Node TintColor Tweaks #1666
Merged
Node TintColor Tweaks #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bolsinga
commented
Sep 9, 2019
bolsinga
commented
- If the tint color changes, be sure to call -setNeedsDisplay on the view.
- Explictly declare tintColor ivar and getter method.
- If the tintColor is the same as the existing one, early-exit.
- Use the ivar and not the property when setting the tintColor, just as is done for background color.
- Add tests that the tintColor will call -setNeedsDisplay
- Backfill tests to document/verify the tintColor behavior on a node.
- If the tint color changes, be sure to call -setNeedsDisplay on the view. - Explictly declare tintColor ivar and getter method. - If the tintColor is the same as the existing one, early-exit. - Use the ivar and not the property when setting the tintColor, just as is done for background color. - Add tests that the tintColor will call -setNeedsDisplay - Backfill tests to document/verify the tintColor behavior on a node.
rahul-malik
reviewed
Sep 10, 2019
rahul-malik
reviewed
Sep 11, 2019
rahul-malik
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.