Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node TintColor Tweaks #1666

Merged
merged 4 commits into from
Sep 11, 2019
Merged

Node TintColor Tweaks #1666

merged 4 commits into from
Sep 11, 2019

Commits on Sep 9, 2019

  1. Node TintColor Tweaks

    - If the tint color changes, be sure to call -setNeedsDisplay on the view.
    - Explictly declare tintColor ivar and getter method.
    - If the tintColor is the same as the existing one, early-exit.
    - Use the ivar and not the property when setting the tintColor, just as is done for background color.
    - Add tests that the tintColor will call -setNeedsDisplay
    - Backfill tests to document/verify the tintColor behavior on a node.
    Greg Bolsinga committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    ff36001 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. fix test for ios 13

    Greg Bolsinga committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    d01c98c View commit details
    Browse the repository at this point in the history
  2. make test work in and out of ios13

    Greg Bolsinga committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    9b611db View commit details
    Browse the repository at this point in the history
  3. add comment about ios13 and setNeedsDisplay

    Greg Bolsinga committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    6548454 View commit details
    Browse the repository at this point in the history