introduction of ASGraphicsCreateImageWithTraitCollectionAndOptions
#1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovasty
force-pushed
the
vlad/ASGraphicsCreateImageWithTraitCollectionAndOptions
branch
from
329075e
to
0c79bbe
Compare
bolsinga
reviewed
Sep 16, 2019
Source/AsyncDisplayKit.h
Outdated
| @@ -130,3 +130,5 @@ | |||
| #import <AsyncDisplayKit/IGListAdapter+AsyncDisplayKit.h> | |||
| #import <AsyncDisplayKit/AsyncDisplayKit+IGListKitMethods.h> | |||
| #import <AsyncDisplayKit/ASLayout+IGListKit.h> | |||
|
|
|||
There was a problem hiding this comment.
please remove this whitespace.
vovasty
force-pushed
the
vlad/ASGraphicsCreateImageWithTraitCollectionAndOptions
branch
3 times, most recently
from
0c8d59d
to
2c29705
Compare
rahul-malik
approved these changes
Sep 16, 2019
Source/Details/ASGraphicsContext.h
Outdated
| * | ||
| * @return The rendered image. You can also render intermediary images using UIGraphicsGetImageFromCurrentImageContext. | ||
| */ | ||
| NS_AVAILABLE_IOS(13) |
There was a problem hiding this comment.
Use AS_AVAILABLE_IOS_TVOS(13,13)
vovasty
force-pushed
the
vlad/ASGraphicsCreateImageWithTraitCollectionAndOptions
branch
from
2c29705
to
11e5992
Compare
vovasty
force-pushed
the
vlad/ASGraphicsCreateImageWithTraitCollectionAndOptions
branch
from
11e5992
to
5a207b5
Compare
rahul-malik
reviewed
Sep 16, 2019
| @@ -27,6 +28,22 @@ NS_ASSUME_NONNULL_BEGIN | |||
| * | |||
| * @return The rendered image. You can also render intermediary images using UIGraphicsGetImageFromCurrentImageContext. | |||
| */ | |||
| AS_EXTERN UIImage *ASGraphicsCreateImageWithOptions(CGSize size, BOOL opaque, CGFloat scale, UIImage * _Nullable sourceImage, asdisplaynode_iscancelled_block_t NS_NOESCAPE _Nullable isCancelled, void (NS_NOESCAPE ^work)()); | |||
| AS_EXTERN UIImage *ASGraphicsCreateImageWithOptions(CGSize size, BOOL opaque, CGFloat scale, UIImage * _Nullable sourceImage, asdisplaynode_iscancelled_block_t NS_NOESCAPE _Nullable isCancelled, void (NS_NOESCAPE ^work)(void)); | |||
There was a problem hiding this comment.
Should we deprecate? There is ASDISPLAYNODE_DEPRECATED_MSG which can be used here
There was a problem hiding this comment.
I think it is appropriate to deprecate since it the existing interface is insufficient for correctness.
There was a problem hiding this comment.
Just talked to @vovasty and we'll deprecate in a follow-up PR
rahul-malik
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASGraphicsCreateImageWithOptionsuses global trait collection cause it runs in the background, thus colors, etc. inworkblock might receive wrong trait collection (e.g. switching dark/light mode when app in the background).ASGraphicsCreateImageWithTraitCollectionAndOptionssolves this problem by taking a trait collection as a parameter and running a drawing code inside of[[UITraitCollection -performAsCurrentTraitCollection:]