Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate ASGraphicsCreateImageWithOptions #1676

Closed
wants to merge 1 commit into from
Closed

deprecate ASGraphicsCreateImageWithOptions #1676

wants to merge 1 commit into from

Conversation

vovasty
Copy link
Contributor

@vovasty vovasty commented Sep 17, 2019 •
edited
Loading

ASGraphicsCreateImageWithTraitCollectionAndOptions supersedes ASGraphicsCreateImageWithOptions, thus we deprecate it.
Reference #1675

UIImage (ASDKResizableRoundedRects) is untouched cause requires deprecation of other things
Documentation wasn't created
ASImageNode Extras remains untouched: needs further deprecation(?)

bolsinga
bolsinga reviewed Sep 17, 2019
View reviewed changes
Source/Details/ASGraphicsContext.mm Outdated
@@ -12,6 +12,22 @@
#import <AsyncDisplayKit/ASInternalHelpers.h>
#import <AsyncDisplayKit/ASAvailability.h>


#if AS_AT_LEAST_IOS13
#define DO_WORK(work) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe PERFORM_WORK_WITH_TRAIT_COLLECTION() for clarity?

@vovasty vovasty force-pushed the vlad/ASGraphicsCreateImageWithOptions-deprecate branch 2 times, most recently from 4a86d0b to 655f3bd Compare September 17, 2019 22:16
@vovasty vovasty force-pushed the vlad/ASGraphicsCreateImageWithOptions-deprecate branch from 655f3bd to 40af879 Compare September 25, 2019 18:25
@vovasty vovasty force-pushed the vlad/ASGraphicsCreateImageWithOptions-deprecate branch from 40af879 to a1c827b Compare September 25, 2019 18:28
@vovasty vovasty closed this Sep 26, 2019
@vovasty vovasty reopened this Sep 26, 2019
@vovasty vovasty mentioned this pull request Oct 8, 2019
Closed
@vovasty vovasty closed this Oct 8, 2019
@vovasty vovasty reopened this Oct 8, 2019
@vovasty vovasty mentioned this pull request Oct 9, 2019
Merged
@vovasty
Copy link
Contributor Author

vovasty commented Oct 9, 2019

I close this PR cause CI is crazy
#1704

@vovasty vovasty closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolsinga bolsinga bolsinga left review comments

@mikezucc mikezucc mikezucc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vovasty @mikezucc @bolsinga