[ASDisplayNode] Implement accessibilityElementsHidden #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of this code comes from an old PR that @fruitcoder put up TextureGroup#795 2 years ago. When creating our array of accessibilityElements, we need to respect the value of `accessibilityElementsHidden`. If the value of this property changes, we need to invalidate the cached accessibility elements (unless we are in the experiment that doesn’t cache `accessibilityElements`). I created a simple test app and made sure this matched UIKit’s implementation. I also added a test case that changes the value of `accessibilityElementsHidden` and makes sure the proper accessibilityElements are returned.
|
@rcancro Wow, that looks great! Thanks for implementing this 👍 |
Talked with huy and decided to make a method to check if a node is hidden, transparent or has `accessibilityElementsHidden` set to yes. Use this in 2 places when collecting accessibility elements to early exit or filter nodes.
piotrdebosz
pushed a commit
to getstoryteller/Texture
that referenced
this pull request
Mar 1, 2021
) Most of this code comes from an old PR that @fruitcoder put up TextureGroup#795 2 years ago. When creating our array of accessibilityElements, we need to respect the value of `accessibilityElementsHidden`. If the value of this property changes, we need to invalidate the cached accessibility elements (unless we are in the experiment that doesn’t cache `accessibilityElements`). I created a simple test app and made sure this matched UIKit’s implementation. I also added a test case that changes the value of `accessibilityElementsHidden` and makes sure the proper accessibilityElements are returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this code comes from an old PR that @fruitcoder put up #795 2 years ago.
When creating our array of accessibilityElements, we need to respect the value of
accessibilityElementsHidden. If the value of this property changes, we need to invalidate the cached accessibility elements (unless we are in the experiment that doesn’t cacheaccessibilityElements).I created a simple test app and made sure this matched UIKit’s implementation. I also added a test case that changes the value of
accessibilityElementsHiddenand makes sure the proper accessibilityElements are returned.