Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASDisplayNode] Implement accessibilityElementsHidden #1859

Merged
merged 2 commits into from
Jun 3, 2020

Commits on Jun 1, 2020

  1. [ASDisplayNode] Implement accessibilityElementsHidden

    Most of this code comes from an old PR that @fruitcoder put up TextureGroup#795 2 years ago.
    
    When creating our array of accessibilityElements, we need to respect the value of `accessibilityElementsHidden`. If the value of this property changes, we need to invalidate the cached accessibility elements (unless we are in the experiment that doesn’t cache `accessibilityElements`).
    
    I created a simple test app and made sure this matched UIKit’s implementation. I also added a test case that changes the value of `accessibilityElementsHidden` and makes sure the proper accessibilityElements are returned.
    rcancro committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    f2ab908 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. add method to check if a node should be ignored by voice over

    Talked with huy and decided to make a method to check if a  node is hidden, transparent or has `accessibilityElementsHidden` set to yes. Use this in 2 places when collecting accessibility elements to early exit or filter nodes.
    rcancro committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    f1efe70 View commit details
    Browse the repository at this point in the history