[Layout transition] Invalidate calculated layout if transitioning using the same size range #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
force-pushed
the
HNInvalidateTransitionedLayout
branch
2 times, most recently
from
8d446db
to
e8f840b
Compare
- It's possible that -transitionLayoutWithSizeRange: can be called with the same size range used for previous layout passes. In that case, it's necessary to invalidate the current layout to avoid it being reused later on in the process.
nguyenhuy
force-pushed
the
HNInvalidateTransitionedLayout
branch
from
e8f840b
to
4e516b8
Compare
maicki
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
@nguyenhuy I guess you tested it very thoroughly with Pinterest, except a small comment it looks good to me.
| return; | ||
| } | ||
|
|
||
| if (ASHierarchyStateIncludesLayoutPending(_hierarchyState)) { |
There was a problem hiding this comment.
Can there be any problems if we call ASHierarchyStateIncludesLayoutPending while holding the lock?
Adlai-Holler
approved these changes
Jul 24, 2017
This was referenced Jul 24, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…ng the same size range (TextureGroup#464) * Invalidate the calculated layout transitioning using the same size range - It's possible that -transitionLayoutWithSizeRange: can be called with the same size range used for previous layout passes. In that case, it's necessary to invalidate the current layout to avoid it being reused later on in the process. * Fix CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #463. It's possible that
-transitionLayoutWithSizeRange:can be called with the same size range used for previous layout passes. In that case, it's necessary to invalidate the current layout to avoid it being reused later on in the process.