Invalidate layouts more aggressively when transitioning with animation #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debug method, fix some build errors when verbose logging
nguyenhuy
approved these changes
Jul 27, 2017
|
Thanks for reviewing this while on vacation. I hope it didn’t interfere too badly. |
|
This is a great change - thank you, Adlai!
…On Wed, Jul 26, 2017 at 10:28 PM Adlai Holler ***@***.***> wrote:
Merged #476 <#476>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#476 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAigA2lhnblqs_FskBRoxpXH959pg8R2ks5sSB_ggaJpZM4Okp-B>
.
|
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
TextureGroup#476) * Be more aggressive at invalidating layouts during transitions, add a debug method, fix some build errors when verbose logging * Add a changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further fix to #464 that addresses the additional case mentioned in #463 as a follow-up.
transitionLayoutWithSizeRangeis now an unconditional layout invalidation, unless the transition is canceled using the pre-existing logic.As ridealongs, I added a
detailedLayoutDescriptionproperty to ASDisplayNode that can be useful when debugging, and I fixed two tiny instances of stale code that caused build errors when verbose logging was enabled. cc @appleguy as this new property may be particularly handy for you, as LLDB does not play well with the C++ structs we use for display node layouts.