Avoid re-entrant call to self.view when applying initial pending state #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
changed the title
nguyenhuy
approved these changes
Aug 14, 2017
garrettmoon
approved these changes
Aug 14, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
TextureGroup#510) * Avoid re-entrant call to .view * Increment the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing a crash in Pinterest like the one attached below.
I don't know why the re-entrant call to self.view would not return immediately (since _view is not nil as guaranteed by the
_loadViewOrLayermethod), and I don't know why we're getting a KERN_PROTECTION_FAILURE, but either way, I believe this is the correct code for the_locked_method.