ASTextKitComponents needs to be deallocated on main #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
2 tasks
maicki
force-pushed
the
MSDeallocTextKitComponentsMainSimple
branch
from
f4991d7
to
4718b9a
Compare
|
🚫 CI failed with log |
Generated by 🚫 Danger |
appleguy
approved these changes
Oct 4, 2017
There was a problem hiding this comment.
IMO, this is the best solution to go with right now. We can ship out this release because it also includes the important fix for a default size for the PINDiskCache... (previous releases had unlimited size!).
Then we can discuss the other PR a bit more and see if any ideas to improve come up?
nguyenhuy
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain objects need to be deallocated on main. We have an automatic mechanism were it goes through each ivar and checks if the object needs to be deallocated on main or not. We have to add
ASTextKitComponentsto this list of classes now.There are multiple ways to tackle this issue, this PR just adds the class right into the method that checks for classes who should be deallocated on main. It will have the problem as we check it with a string comparison if we change the name of the ASTextKitComponents we could miss this change in here as well as if we would like to add new classes this can easily hard to maintain.
I will follow up with a PR that is more flexible approach, but it will add some overhead.
Adresses #586