Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASTextKitComponents needs to be deallocated on main #598

Merged
merged 1 commit into from
Oct 4, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Source/Private/ASInternalHelpers.m
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ void ASPerformBackgroundDeallocation(id object)

BOOL ASClassRequiresMainThreadDeallocation(Class c)
{
// Specific classes
if (c == [UIImage class] || c == [UIColor class]) {
return NO;
}
Expand All @@ -101,10 +102,16 @@ BOOL ASClassRequiresMainThreadDeallocation(Class c)
return YES;
}

// Apple classes with prefix
const char *name = class_getName(c);
if (strncmp(name, "UI", 2) == 0 || strncmp(name, "AV", 2) == 0 || strncmp(name, "CA", 2) == 0) {
return YES;
}

// Specific Texture classes
if (strncmp(name, "ASTextKitComponents", 19) == 0) {
return YES;
}

return NO;
}
Expand Down