[ASTextKitComponents] Temporary components can be deallocated off main #trivial #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
nguyenhuy
force-pushed
the
HNTemporaryTextKitComponentsDeallocation
branch
from
4d85717
to
1ccb858
Compare
nguyenhuy
changed the title
|
🚫 CI failed with log |
|
🚫 CI failed with log |
nguyenhuy
added a commit
to nguyenhuy/Texture
that referenced
this pull request
Oct 10, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#603 unnecessarily triggers assertions when temporary components that are created here and here are deallocated off the main thread. Fix (and close #607) by not asserting on these objects.