Enable tvOS support #653
Closed
Enable tvOS support #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🚫 CI failed with log |
nguyenhuy
requested changes
Nov 2, 2017
There was a problem hiding this comment.
@Eke Thanks for volunteering to handle tvOS support. Here is the first issue reported by CI:
- ERROR | [Texture/Core, Texture/PINRemoteImage, Texture/IGListKit, and more...] xcodebuild: /Users/Shared/buildkite/builds/iosf-garrett-VMrmmvuqKsO4.dyn.pinadmin.com-1/pinterest/texture/Source/tvOS/ASImageNode+tvOS.m:31:10: error: no visible @interface for 'ASControlNode' declares the selector 'touchesBegan:withEvent:'
- ERROR | [Texture/Core, Texture/PINRemoteImage, Texture/IGListKit, and more...] xcodebuild: /Users/Shared/buildkite/builds/iosf-garrett-VMrmmvuqKsO4.dyn.pinadmin.com-1/pinterest/texture/Source/tvOS/ASImageNode+tvOS.m:67:10: error: no visible @interface for 'ASControlNode' declares the selector 'touchesMoved:withEvent:'
- ERROR | [Texture/Core, Texture/PINRemoteImage, Texture/IGListKit, and more...] xcodebuild: /Users/Shared/buildkite/builds/iosf-garrett-VMrmmvuqKsO4.dyn.pinadmin.com-1/pinterest/texture/Source/tvOS/ASImageNode+tvOS.m:132:10: error: no visible @interface for 'ASControlNode' declares the selector 'touchesEnded:withEvent:'
I think you need #import <AsyncDisplayKit/ASDisplayNode+Subclasses.h> in ASImageNode+tvOS.m.
|
Thanks @nguyenhuy ! Strange, it was working locally. I will take a look ASAP and will fix it. |
|
🚫 CI failed with log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I re-enabled tvOS support which was disabled by this commit.
At this moment everything works fine locally, but if there are some more details i need to know, please let me know. We have the project which needs tvOS support, so i'm ready to take this part over and fix everything.