Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS11] Update project settings and fix errors #676

Merged
merged 4 commits into from
Nov 30, 2017
Merged

[iOS11] Update project settings and fix errors #676

merged 4 commits into from
Nov 30, 2017

Conversation

Eke
Copy link
Contributor

@Eke Eke commented Nov 15, 2017 •
edited
Loading

Hello!

I fixed some warnings in Xcode 9 and iOS 11. There are still some warnings in dependencies when running pod lib lint --verbose. This PR can unblock me with #653

Testing with xcodebuild.
 -> Texture (2.6)
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/IGListUpdatingDelegate.h:34:38: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/IGListUpdatingDelegate.h:38:40: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/IGListAdapter.m:941:18: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/Internal/IGListBatchUpdates.h:26:64: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/IGListAdapterUpdater.m:425:50: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/IGListAdapterUpdater.m:55:26: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/IGListAdapterUpdater.m:133:32: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  IGListKit/Source/IGListAdapterUpdater.m:181:24: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  {{PATH}}/Xcode/DerivedData/App-akhbasdbsjtjlsgxcsxwstypgecs/Build/Products/Release-iphonesimulator/IGListKit/IGListKit.framework/Headers/IGListUpdatingDelegate.h:34:38: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/IGListKit] xcodebuild:  {{PATH}}/Xcode/DerivedData/App-akhbasdbsjtjlsgxcsxwstypgecs/Build/Products/Release-iphonesimulator/IGListKit/IGListKit.framework/Headers/IGListUpdatingDelegate.h:38:40: warning: this block declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [Texture/Yoga] xcodebuild:  {{PATH}}/Texture/Source/ASDisplayNode+Beta.h:180:44: warning: 'UISemanticContentAttribute' is partial: introduced in iOS 9.0 [-Wunguarded-availability]
    - NOTE  | [Texture/Yoga] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIView.h:121:28: note: 'UISemanticContentAttribute' has been explicitly marked partial here
    - NOTE  | [Texture/Yoga] xcodebuild:  /{{PATH}}/Texture/Source/ASDisplayNode+Beta.h:180:1: note: annotate 'semanticContentAttributeDidChange:' with an availability attribute to silence
    - WARN  | [Texture/Yoga] xcodebuild:  /{{PATH}}/Texture/Source/ASDisplayNode+Yoga.mm:95:44: warning: 'UISemanticContentAttribute' is partial: introduced in iOS 9.0 [-Wunguarded-availability]
    - NOTE  | [Texture/Yoga] xcodebuild:  /{{PATH}}/Texture/Source/ASDisplayNode+Yoga.mm:95:1: note: annotate 'semanticContentAttributeDidChange:' with an availability attribute to silence
    - WARN  | [Texture/Yoga] xcodebuild:  /{{PATH}}/Texture/Source/ASDisplayNode+Yoga.mm:99:13: warning: 'userInterfaceLayoutDirectionForSemanticContentAttribute:' is only available on iOS 9.0 or newer [-Wunguarded-availability]
    - NOTE  | [Texture/Yoga] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.1.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIView.h:167:1: note: 'userInterfaceLayoutDirectionForSemanticContentAttribute:' has been explicitly marked partial here
    - NOTE  | [Texture/Yoga] xcodebuild:  /{{PATH}}/Texture/Source/ASDisplayNode+Yoga.mm:99:13: note: enclose 'userInterfaceLayoutDirectionForSemanticContentAttribute:' in an @available check to silence this warning
    - WARN  | [Texture/Yoga] xcodebuild:  /{{PATH}}/Xcode/DerivedData/App-akhbasdbsjtjlsgxcsxwstypgecs/Build/Products/Release-iphonesimulator/Texture/AsyncDisplayKit.framework/Headers/ASDisplayNode+Beta.h:180:44: warning: 'UISemanticContentAttribute' is partial: introduced in iOS 9.0 [-Wunguarded-availability]
    - NOTE  | [Texture/Yoga] xcodebuild:  /{{PATH}}/Xcode/DerivedData/App-akhbasdbsjtjlsgxcsxwstypgecs/Build/Products/Release-iphonesimulator/Texture/AsyncDisplayKit.framework/Headers/ASDisplayNode+Beta.h:180:1: note: annotate 'semanticContentAttributeDidChange:' with an availability attribute to silence

Also i opened PR for PINRemoteImage.

UPD:
Here is the log of current master branch warnings

Eke
Eke commented Nov 15, 2017
View reviewed changes
Tests/ASDisplayLayerTests.m
@@ -472,7 +472,7 @@ - (void)DISABLED_testTransaction
layer1.displaysAsynchronously = YES;

dispatch_semaphore_t displayAsyncLayer1Sema = dispatch_semaphore_create(0);
layer1Delegate.displayLayerBlock = ^(_ASDisplayLayer *asyncLayer) {
layer1Delegate.displayLayerBlock = ^UIImage *{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one, tests are green but..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me :)

@Kaspik
Copy link
Contributor

Kaspik commented Nov 25, 2017

👍 for this PR, currently warnings from Texture like This block declaration is not a prototype are the only ones in our project.

garrettmoon
garrettmoon approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for fixing it up!

Source/Base/ASLog.h Outdated
} \

#define as_log_info(log, format, ...) \
if (AS_AVAILABLE_IOS(9)) { \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indent \

Source/Base/ASLog.h Outdated
os_log_info(log, format, ##__VA_ARGS__); \
} else { \
(void)0; \
}\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Source/Base/ASLog.h
#define as_log_fault(log, format, ...) (AS_AT_LEAST_IOS9 ? os_log_fault(log, format, ##__VA_ARGS__) : (void)0)

#define as_log_create(subsystem, category) ({ \
os_log_t __val; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the rest of the macros need to pass through their return value as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i did not miss anything, other macros don't need to pass through their return value as well.

Tests/ASDisplayLayerTests.m
@@ -472,7 +472,7 @@ - (void)DISABLED_testTransaction
layer1.displaysAsynchronously = YES;

dispatch_semaphore_t displayAsyncLayer1Sema = dispatch_semaphore_create(0);
layer1Delegate.displayLayerBlock = ^(_ASDisplayLayer *asyncLayer) {
layer1Delegate.displayLayerBlock = ^UIImage *{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me :)

@ghost
Copy link

ghost commented Nov 28, 2017

🚫 CI failed with log

@Eke
Copy link
Contributor Author

Eke commented Nov 28, 2017

Hello @garrettmoon, thank you for review. I resolved your comments. Tests are green on my local machine, i have no idea why they failed with CI.

@Kaspik
Copy link
Contributor

Kaspik commented Nov 29, 2017

@Eke Merge master in to restart the test and see if we can make this PR more up-to-date. :)

@nguyenhuy
Copy link
Member

Alright, all green! Merging per @garrettmoon's review. Thank you all!

@nguyenhuy nguyenhuy merged commit d8cda8d into TextureGroup:master Nov 30, 2017
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
@Eke @bernieperez
[iOS11] Update project settings and fix errors (TextureGroup#676)
3a3be29 
* [iOS11] Update project settings and fix errors

* update changelog

* resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Eke @Kaspik @nguyenhuy @garrettmoon