-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS11] Fix warnings #428
[iOS11] Fix warnings #428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing! Would you mind fixing the spacing in the pod spec and then I'll merge?
PINRemoteImage.podspec
Outdated
@@ -76,7 +76,9 @@ Pod::Spec.new do |s| | |||
s.subspec "PINCache" do |pc| | |||
pc.dependency 'PINRemoteImage/Core' | |||
pc.dependency 'PINCache', '=3.0.1-beta.6' | |||
pc.osx.deployment_target = osx_deployment | |||
pc.ios.deployment_target = ios_deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor nit: mind fixing the spacing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem, will fix tomorrow morning. Thank you for review
…into warning-fixes
[self.session getAllTasksWithCompletionHandler:^(NSArray<__kindof NSURLSessionTask *> * _Nonnull tasks) { | ||
concurrentDownloadsCompletion(tasks.count); | ||
}]; | ||
if (@available(macos 10.11, iOS 9.0, watchOS 2.0, tvOS 9.0, *)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garrettmoon I remember we talked about not using @available
to support Xcode < 9. Is this still the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maicki yeah, still shooting for that, but it'll be on top of this and will be a macro which uses @availabile
on Xcode 9.
Hello!
I fixed some warnings in Xcode 9 and iOS 11. Also re-enabled iOS and tvOS support for
PINCache
inPINRemoteImage.podspec
, i think it was disabled in #421 .After that PR was merged users got error(was reported in Texture slack channel too) :