[ASDisplayNode] Always return the thread-safe cornerRadius property, even in slow CALayer rounding mode #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
commented
Jan 16, 2018
| } | ||
|
|
||
| - (void)setCornerRadius:(CGFloat)newCornerRadius | ||
| { | ||
| ASDN::MutexLocker l(__instanceLock__); |
There was a problem hiding this comment.
-updateCornerRoundingWithType:cornerRadius: acquires the lock itself (here).
maicki
approved these changes
Jan 16, 2018
nguyenhuy
changed the title
nguyenhuy
force-pushed
the
HNCornerRadiusRaceCondition
branch
2 times, most recently
from
84d114a
to
5b13c16
Compare
…layNode, even in slow CALayer rounding type - Failing to do so will introduce race conditions in which the property was updated on a background thread but main thread has not executed the block that updates the property of the node's layer. During that window, the layer's property is out-of-date and can't be used. - After this change, ASDisplayNode's cornerRadius is the only source of truth and users must always use it instead of CALayer's.
nguyenhuy
force-pushed
the
HNCornerRadiusRaceCondition
branch
from
5b13c16
to
af5cc07
Compare
| @@ -207,7 +202,6 @@ - (ASCornerRoundingType)cornerRoundingType | |||
|
|
|||
| - (void)setCornerRoundingType:(ASCornerRoundingType)newRoundingType | |||
| { | |||
| ASDN::MutexLocker l(__instanceLock__); | |||
| [self updateCornerRoundingWithType:newRoundingType cornerRadius:_cornerRadius]; | |||
There was a problem hiding this comment.
Isn't this public? Think we should read self.cornerRadius?
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…even in slow CALayer rounding mode (TextureGroup#749) - Failing to do so will introduce race conditions in which the property was updated on a background thread but main thread has not executed the block that updates the property of the node's layer. During that window, the layer's property is out-of-date and can't be used. - After this change, ASDisplayNode's cornerRadius is the only source of truth and users must always use it instead of CALayer's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cornerRadiusof the node's layer, the layer's property is out-of-date and shouldn't be used.Relevant PR: #465.
Recorded bug here - Pay attention to the "Save" button on the top right corner.