Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASDisplayNode] Always return the thread-safe cornerRadius property, even in slow CALayer rounding mode #749

Merged

Commits on Jan 16, 2018

  1. Always return the backing thread-safe cornerRadius property of ASDisp…

    …layNode, even in slow CALayer rounding type
    
    - Failing to do so will introduce race conditions in which the property was updated on a background thread but main thread has not executed the block that updates the property of the node's layer. During that window, the layer's property is out-of-date and can't be used.
    - After this change, ASDisplayNode's cornerRadius is the only source of truth and users must always use it instead of CALayer's.
    nguyenhuy committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    b0fdd74 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG

    nguyenhuy committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    af5cc07 View commit details
    Browse the repository at this point in the history
  3. Update CHANGELOG.md

    nguyenhuy committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    fdd93ff View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. Call getters

    nguyenhuy committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    bae219b View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Configuration menu
    Copy the full SHA
    78c5070 View commit details
    Browse the repository at this point in the history