-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node tint color #764
Node tint color #764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a second to understand this but it makes perfect sense – we want the tint color to propagate out from the cell node to the actual cell.
Thanks @ShogunPhyched
Generated by 🚫 Danger |
@ShogunPhyched Alright if you'll update the change log, I'll land this today. |
@Adlai-Holler I've already deleted my fork for Texture, so I'm unable to change anything in this pull request. Do you want me to create a new pull request? |
@ShogunPhyched Ah, no big deal man. I'll land this and manually update the change log. Thanks for the fix, I bet other people faced this too. |
@Adlai-Holler okay, thanks. |
I faced a small problem with tint color when working with TableView cells. If you create cell in a table view, set accessory and tint color, then tint color will not apply to cell.
It happens because tintColor wasn't pass inside ASTableView. I fixed it so setting tintColor works fine now.