[ASRangeController] Fix stability of "minimum" rangeMode if the app has more than one layout before scrolling. #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as more than one layout before scrolling. This should result in memory savings in many apps, since errant relayouts are pretty common.
Closed
Adlai-Holler
reviewed
Feb 7, 2018
There was a problem hiding this comment.
This is a good improvement.
Using scrollViewDidScroll: to trigger the state change may still be noisy. I've seen that callback fire errantly although I don't remember the details. One example might be if the user changes the content inset while setting up a header, and then changes the content offset to account for it.
If we used scrollViewWillBeginDragging: that would be very reliable and it would mean the user has engaged with the content. It would not cover animated programmatic scrolls but I think that's OK.
nguyenhuy
approved these changes
Feb 8, 2018
|
@Adlai-Holler good suggestion to use beginDragging! I'll change to that. |
Adlai-Holler
approved these changes
Feb 8, 2018
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…as more than one layout before scrolling. (TextureGroup#790) This should result in memory savings in many apps, since errant relayouts are pretty common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should result in memory savings in many apps, since errant relayouts are pretty common.