Assert node did load before did enter visible way 1 #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wsdwsd0829 Can you add an entry to the changelog please. |
maicki
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
@nguyenhuy Can you also take a look at this change please. It will change the expectation of a node within didEnterVisibleState, before it was kind of not defined if the node was loaded or not.
|
@wsdwsd0829 is this still the latest patch, or did we merge a different solution already? Let's update this and ask for a review once it's ready, if still applicable. |
|
This is the latest, let's try to merge this. |
|
🚫 CI failed with log |
…nodeDidLoad-before-didEnterVisible-1
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * access layer to load node before enter visible * revert space
ernestmama
added a commit
to ernestmama/Texture
that referenced
this pull request
Nov 14, 2018
ernestmama
added a commit
to ernestmama/Texture
that referenced
this pull request
Nov 14, 2018
nguyenhuy
pushed a commit
that referenced
this pull request
Nov 14, 2018
rcancro
added a commit
to rcancro/Texture
that referenced
this pull request
Nov 14, 2018
TextureGroup#886 enforces that some nodes are loaded before they are sent a visiblity event, but it was not propagating the trait collection before forcing the load. We are propagating traits in `_setSupernode:` (which was happening after the forced load). I moved the possible forced load to `_setSupernode:`, after propagating traits but before any visibility states are changed.
nguyenhuy
pushed a commit
that referenced
this pull request
Nov 20, 2018
#886 enforces that some nodes are loaded before they are sent a visiblity event, but it was not propagating the trait collection before forcing the load. We are propagating traits in `_setSupernode:` (which was happening after the forced load). I moved the possible forced load to `_setSupernode:`, after propagating traits but before any visibility states are changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's discuss which way is better #887