[ASDisplayNode] Propagate traits before loading a subnode #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nguyenhuy
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
LGTM. Would be great to have another approval from the core team and @wsdwsd0829.
TextureGroup#886 enforces that some nodes are loaded before they are sent a visiblity event, but it was not propagating the trait collection before forcing the load. We are propagating traits in `_setSupernode:` (which was happening after the forced load). I moved the possible forced load to `_setSupernode:`, after propagating traits but before any visibility states are changed.
rcancro
force-pushed
the
propagateTraitsBeforeLoad
branch
from
c7bed3f
to
f24bf80
Compare
|
LGTM Thanks. |
maicki
approved these changes
Nov 14, 2018
maicki
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#886 enforces that some nodes are loaded before they are sent a visiblity event, but it was not propagating the trait collection before forcing the load.
We are propagating traits in
_setSupernode:(which was happening after the forced load). I moved the possible forced load to_setSupernode:, after propagating traits but before any visibility states are changed.